Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream konstruktoid/ansible-role-hardening (initial refactor for issue 96) #106

Closed
wants to merge 12 commits into from
Closed

Use upstream konstruktoid/ansible-role-hardening (initial refactor for issue 96) #106

wants to merge 12 commits into from

Conversation

konstruktoid
Copy link

@konstruktoid konstruktoid commented May 6, 2024 •
edited by jsf9k
Loading

🗣 Description

This PR is a try to use upstream https://github.com/konstruktoid/ansible-role-hardening in order to close #96, it also incorporates as many changes as possible from https://github.com/cisagov/ansible-role-hardening-2/pulls?q=is%3Apr

💭 Motivation and context

See discussions at cisagov/ansible-role-hardening-2#1 (comment) and #96

🧪 Testing

Due to the AWS and other dependencies, no testing except standard role tests has been done.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use ansible Pull requests that update Ansible code labels May 7, 2024
@konstruktoid @jsf9k
Initial refactor for issue #96
10a2734 
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
@jsf9k jsf9k changed the title use upstream konstruktoid/ansible-role-hardening (initial refactor for issue 96) Use upstream konstruktoid/ansible-role-hardening (initial refactor for issue 96) May 29, 2024
@jsf9k jsf9k added the version bump This issue or pull request increments the version number label May 29, 2024
jsf9k
jsf9k reviewed May 29, 2024
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick, initial review...

src/requirements.yml Outdated Show resolved Hide resolved
src/packer.pkr.hcl Outdated Show resolved Hide resolved
src/upgrade.yml Outdated Show resolved Hide resolved
src/harden.yml Outdated Show resolved Hide resolved
src/harden.yml Outdated Show resolved Hide resolved
src/harden.yml Outdated Show resolved Hide resolved
jsf9k
jsf9k reviewed May 29, 2024
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some comments to explain why we override certain role variables.

src/harden.yml Show resolved Hide resolved
src/harden.yml Show resolved Hide resolved
src/harden.yml Show resolved Hide resolved
src/harden.yml Show resolved Hide resolved
src/harden.yml Outdated Show resolved Hide resolved
src/harden.yml Show resolved Hide resolved
src/harden.yml Show resolved Hide resolved
konstruktoid and others added 11 commits May 29, 2024 23:32
@konstruktoid @jsf9k
Update src/requirements.yml
a1d5abb 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
169c613 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
e9d163b 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
0b3232f 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
8e8d5e2 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
8294bcf 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
80196d2 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid @jsf9k
Update src/harden.yml
7f112e6 
Co-authored-by: Shane Frasier <maverick@maverickdolphin.com>
@konstruktoid
readd src/upgrade.yml
0b8a7f5 
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
@konstruktoid
dont configure automatic updates
7bb90e9 
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
@konstruktoid
readd automated security updates
e552702 
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
@konstruktoid konstruktoid closed this by deleting the head repository Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k left review comments

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
ansible Pull requests that update Ansible code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use konstruktoid/ansible-role-hardening?
3 participants
@konstruktoid @jsf9k @mcdonnnj